Do not reparse the full (already parsed) IOP after new segments arrive - #708
Open
martonmiklos wants to merge 2 commits into
Open
Do not reparse the full (already parsed) IOP after new segments arrive#708martonmiklos wants to merge 2 commits into
martonmiklos wants to merge 2 commits into
Conversation
martonmiklos
force-pushed
the
martonmiklos/do_not_reparse_whole_iop_after_segment_reception
branch
3 times, most recently
from
August 18, 2026 07:53
0e0d97c to
2cda851
Compare
sujandumaru
reviewed
Aug 18, 2026
Member
|
Is it possible to add a test for this? |
martonmiklos
changed the title
martonmiklos
force-pushed
the
martonmiklos/do_not_reparse_whole_iop_after_segment_reception
branch
2 times, most recently
from
September 4, 2026 20:08
2cb879b to
a291862
Compare
Fixes Open-Agriculture/AgIsoVirtualTerminal/#201
martonmiklos
force-pushed
the
martonmiklos/do_not_reparse_whole_iop_after_segment_reception
branch
from
September 4, 2026 20:09
a291862 to
822a31c
Compare
Contributor
Author
I have added an unit test to cover this feature. |
…segment_reception
|
sujandumaru
approved these changes
Sep 5, 2026
sujandumaru
left a comment
sujandumaru
left a comment
Member
There was a problem hiding this comment.
Would be better if we can add the "explicit" on the constructor with one argument as suggested by SonarCloud.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
In the case an IOP segment is being transferred the whole pool is being reparsed.
This means in the case if some object properties (like object hide/show state) are being set by commands after the reparsing these changes will be lost. This goes against the what the standard says about the visibility effect:
Fixes #Open-Agriculture/AgIsoVirtualTerminal/201
How has this been tested?
Built AgIsoVT with this stack version and checked a side effect caused by the reparsing, which is gone after this fix.